feat: merging functions on List + mergeSort #763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
digama0
added
the
awaiting-review
fgdorais
requested changes
Apr 24, 2024
| (i.e. for all `x`, `y`, `y'`, `z`, if `x < y < z` and `x < y' < z` then `x < merge y y' < z`) | ||
| then the resulting list is again sorted. | ||
| -/ | ||
| def mergeDedupWith [Ord α] (merge : α → α → α) : (xs ys : List α) → List α |
There was a problem hiding this comment.
The merge parameter is a bit confusing. How about dedup, join or meld?
There was a problem hiding this comment.
or just f. I think most of the other list functions don't give their predicate and function arguments long names, and while there are some downsides to having lots of one letter variables in context, one upside is that it makes it visibly distinct from global definitions. I assume that's the reason you flagged merge as being a bad name...
There was a problem hiding this comment.
Yes, the issue is that merge clashes with a definition in this file. I'm happy with f, combine or whatever you decide.
Co-authored-by: François G. Dorais <[email protected]>
kim-em
added
awaiting-author
leanprover-community-mathlib4-bot
added
the
merge-conflict
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complement to #762. Adds List version of all the definitions in
Data.Array.Merge. Also addsList.mergeSort(upstreamed from mathlib), as a replacement forArray.qsorton lists (becauseqsortcannot easily be expressed as is).